Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dependency management through npm #5

Merged
merged 1 commit into from
Apr 13, 2023

Conversation

martin-fleck-at
Copy link
Collaborator

@martin-fleck-at martin-fleck-at commented Mar 17, 2023

  • Add support for 'package.json' files
    -- Listen to changes of 'package.json' files
    -- Add VS code plugins to support editing 'package.json' files

  • Add package manager for simple dependency management
    -- Do not build 'package.json' files (as they do not match CM grammar)
    -- Instead build up dependency graph based on package information
    -- Consider models under 'package.json' directory part of the package

  • Replace workspace-based scoping with package-based scoping
    -- Only models within the same models or dependent models are visible
    -- Ensure 'node_modules' directory is also scanned

Minor:

  • Update to latest version of Langium and Theia
  • Convert model service to shared service
    -- Requires retrieval of serializer based on URI
    -- Extend language model service to ensure we have serializer

@martin-fleck-at martin-fleck-at requested a review from planger March 17, 2023 10:00
@martin-fleck-at martin-fleck-at marked this pull request as draft March 17, 2023 10:00
@martin-fleck-at martin-fleck-at marked this pull request as ready for review March 29, 2023 13:30
@martin-fleck-at martin-fleck-at force-pushed the package-management branch 3 times, most recently from ff999f2 to 191a0b5 Compare April 2, 2023 19:43
- Add support for 'package.json' files
-- Listen to changes of 'package.json' files
-- Add VS code plugins to support editing 'package.json' files

- Add package manager for simple dependency management
-- Do not build 'package.json' files (as they do not match CM grammar)
-- Instead build up dependency graph based on package information
-- Consider models under 'package.json' directory part of the package

- Replace workspace-based scoping with package-based scoping
-- Only models within the same models or dependent models are visible
-- Ensure 'node_modules' directory is also scanned

Minor:
- Update to latest version of Langium and Theia
- Convert model service to shared service
-- Requires retrieval of serializer based on URI
-- Extend language model service to ensure we have serializer
Copy link
Collaborator

@planger planger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this looks great!

@martin-fleck-at martin-fleck-at merged commit 1e8e2ea into main Apr 13, 2023
@martin-fleck-at martin-fleck-at deleted the package-management branch April 13, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants